[PATCH] D16183: Added CheckName field to YAML report

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 14 07:22:00 PST 2016


alexfh added a comment.

Thanks for addressing the comments. However, the main concern is this:

In http://reviews.llvm.org/D16183#326759, @alexfh wrote:

> I'm not sure `tooling::Replacement` is the best place to store check name. Maybe create a separate wrapper class and serialize it instead (clang-apply-replacements will have to be changed to support this format as well). This could be `ClangTidyDiagnostic` or just `Diagnostic`, and we could also store the message and other useful information in it.





http://reviews.llvm.org/D16183





More information about the cfe-commits mailing list