[PATCH] D15528: Teach clang-tidy how to -Werror checks.

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

Looks good with a couple of nits. I'll be happy to submit your patch once you address the comments.

Also, please include more context in your patches. See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.


================
Comment at: clang-tidy/ClangTidy.cpp:156
@@ -149,1 +155,3 @@
 
+  unsigned WarningsAsErrorsCount() const { return WarningsAsErrors; }
+
----------------
I'd call it `getWarningsAsErrorsCount()`

================
Comment at: clang-tidy/ClangTidyOptions.cpp:130
@@ +129,3 @@
+    Result.WarningsAsErrors =
+        (Result.WarningsAsErrors && !Result.WarningsAsErrors->empty() ? *Result.WarningsAsErrors + "," : "") +
+        *Other.WarningsAsErrors;
----------------
This line exceeds column limit. Please run clang-format on the changed files.


http://reviews.llvm.org/D15528