[PATCH] D16065: Fix infinite recursion for invalid declaration

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 12 01:05:09 PST 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL257461: Fix infinite recursion for invalid declaration, by Dmitry Polukhin (authored by ABataev).

Changed prior to commit:
  http://reviews.llvm.org/D16065?vs=44499&id=44608#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D16065

Files:
  cfe/trunk/lib/AST/Decl.cpp
  cfe/trunk/test/SemaCXX/linkage-invalid-decl.cpp

Index: cfe/trunk/test/SemaCXX/linkage-invalid-decl.cpp
===================================================================
--- cfe/trunk/test/SemaCXX/linkage-invalid-decl.cpp
+++ cfe/trunk/test/SemaCXX/linkage-invalid-decl.cpp
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+
+// This invalid declaration used to call infinite recursion in linkage
+// calculation for enum as a function argument.
+inline foo(A)(enum E;
+// expected-error at -1 {{unknown type name 'foo'}}
+// expected-error at -2 {{ISO C++ forbids forward references to 'enum' types}}
+// expected-error at -3 {{expected ')'}}
+// expected-note at -4 {{to match this '('}}
Index: cfe/trunk/lib/AST/Decl.cpp
===================================================================
--- cfe/trunk/lib/AST/Decl.cpp
+++ cfe/trunk/lib/AST/Decl.cpp
@@ -1184,7 +1184,7 @@
     return LinkageInfo::none();
 
   const Decl *OuterD = getOutermostFuncOrBlockContext(D);
-  if (!OuterD)
+  if (!OuterD || OuterD->isInvalidDecl())
     return LinkageInfo::none();
 
   LinkageInfo LV;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16065.44608.patch
Type: text/x-patch
Size: 1036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160112/84718470/attachment.bin>


More information about the cfe-commits mailing list