[PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.
Manuel Klimek via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 11 02:10:38 PST 2016
klimek added a reviewer: bkramer.
================
Comment at: test/SemaTemplate/temp_arg_template.cpp:80
@@ +79,3 @@
+#if __cplusplus >= 201103L
+ static constexpr int N = sizeof...(Templates);
+#endif
----------------
dblaikie wrote:
> It would be good if we tested for some specific behavior here other than "don't crash" (doing anything other than crashing is a bit underspecified) - maybe we should be testing that N has the right value?
>
> (don't have quite enough context on the fix itself to sign off on it though, unfortunately :/)
Done.
http://reviews.llvm.org/D15743
More information about the cfe-commits
mailing list