[PATCH] D15911: Move ownership of Action objects into Compilation.

Artem Belevich via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 8 10:08:30 PST 2016


tra added inline comments.

================
Comment at: include/clang/Driver/Action.h:36
@@ -35,1 +35,3 @@
+///
+/// Actions are usually owned by a Compilation.
 class Action {
----------------
There's no API to pass ownership to Compilation explicitly, so the only way for an Action to be owned by Compilation is to create it with MakeAction. 

Perhaps "Actions created with MakeAction<>() are owned by Compilation"

BTW, should we (can we?) make MakeAction<>() the only way to create actions?


http://reviews.llvm.org/D15911





More information about the cfe-commits mailing list