[PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 8 01:53:34 PST 2016


hokein marked 4 inline comments as done.

================
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:22
@@ +21,3 @@
+
+AST_MATCHER(NamedDecl, useHeaderFileExtension) {
+  SourceManager& SM = Finder->getASTContext().getSourceManager();
----------------
alexfh wrote:
> nit: This name is not clear to me. Did you mean `isHeaderFileExtension` or `usesHeaderFileExtension`?
`IsHeaderFileExtension` is more descriptive. Have renamed to it now.


http://reviews.llvm.org/D15710





More information about the cfe-commits mailing list