[PATCH] D15881: [DWARF] Omitting the explicit import of an anonymous namespace is a debugger-tuning decision, not a target decision.

[Eric Christopher via cfe-commits]

echristo added inline comments.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
   Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
-  Opts.DebugExplicitImport = Triple.isPS4CPU(); 
+  Opts.DebugExplicitImport =
+      Opts.getDebuggerTuning() != CodeGenOptions::DebuggerKindGDB &&
+      Opts.getDebuggerTuning() != CodeGenOptions::DebuggerKindLLDB;
 
----------------
probinson wrote:
> echristo wrote:
> > Why not just a positive for debugger tuning SCE?
> Because the default (i.e., no tuning specified) behavior should be to conform to the DWARF spec, which basically says you need the explicit import.  There's a new extra RUN line in the test, with no tuning specified, to verify this.
> GDB and LLDB are the oddballs here, they implement a special case for namespaces whose name meets certain criteria, and do something beyond what DWARF says to do.  So, the condition is written to express that.
> 
I don't necessarily agree with that interpretation on the explicit import - I did skim the thread, perhaps you could highlight what makes you think this?


http://reviews.llvm.org/D15881