[PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

[Justin Lebar via cfe-commits]

jlebar updated this revision to Diff 44154.
jlebar added a dependency: D15911: Switch Action and ActionList over to using std::shared_ptr..
jlebar added a comment.

Rebasing onto http://reviews.llvm.org/D15911.

Depends on http://reviews.llvm.org/D15911.


http://reviews.llvm.org/D15936

Files:
  lib/Driver/Driver.cpp

Index: lib/Driver/Driver.cpp
===================================================================
--- lib/Driver/Driver.cpp
+++ lib/Driver/Driver.cpp
@@ -1297,11 +1297,12 @@
   SmallVector<const char *, 4> GpuArchList;
   llvm::StringSet<> GpuArchNames;
   for (Arg *A : Args) {
-    if (A->getOption().matches(options::OPT_cuda_gpu_arch_EQ)) {
-      A->claim();
-      if (GpuArchNames.insert(A->getValue()).second)
-        GpuArchList.push_back(A->getValue());
+    if (!A->getOption().matches(options::OPT_cuda_gpu_arch_EQ)) {
+      continue;
     }
+    A->claim();
+    if (GpuArchNames.insert(A->getValue()).second)
+      GpuArchList.push_back(A->getValue());
   }
 
   // Default to sm_20 which is the lowest common denominator for supported GPUs.
@@ -1324,13 +1325,9 @@
          "Failed to create actions for all devices");
 
   // Check whether any of device actions stopped before they could generate PTX.
-  bool PartialCompilation = false;
-  for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) {
-    if (CudaDeviceActions[I]->getKind() != Action::BackendJobClass) {
-      PartialCompilation = true;
-      break;
-    }
-  }
+  bool PartialCompilation = std::any_of(
+      CudaDeviceActions.begin(), CudaDeviceActions.end(),
+      [](const Action *a) { return a->getKind() != Action::BackendJobClass; });
 
   // Figure out what to do with device actions -- pass them as inputs to the
   // host action or run each of them independently.
@@ -1468,12 +1465,11 @@
       continue;
     }
 
-    phases::ID CudaInjectionPhase = FinalPhase;
-    for (const auto &Phase : PL)
-      if (Phase <= FinalPhase && Phase == phases::Compile) {
-        CudaInjectionPhase = Phase;
-        break;
-      }
+    phases::ID CudaInjectionPhase =
+        (phases::Compile < FinalPhase &&
+         std::find(PL.begin(), PL.end(), phases::Compile) != PL.end())
+            ? phases::Compile
+            : FinalPhase;
 
     // Build the pipeline for this file.
     std::shared_ptr<Action> Current =


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15936.44154.patch
Type: text/x-patch
Size: 2014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160106/c7ec2774/attachment.bin>