[PATCH] D15861: Support fully-qualified names for all QualTypes

[Nick Lewycky via cfe-commits]

nlewycky added a subscriber: nlewycky.
nlewycky added a comment.

(I'm not doing a full review, I just happened to notice a couple things when skimming.)


================
Comment at: lib/Tooling/Core/QualTypeNames.cpp:250
@@ +249,3 @@
+    // There are probably other cases ...
+    if (const TagType *TagDeclType = llvm::dyn_cast_or_null<TagType>(TypePtr))
+      Decl = TagDeclType->getDecl();
----------------
s/dyn_cast_or_null/dyn_cast/

You've already checked !TypePtr above, so it can't be null here.

================
Comment at: lib/Tooling/Core/QualTypeNames.cpp:306
@@ +305,3 @@
+  // In case of myType& we need to strip the reference first, fully
+  // qualifiy and attach the reference once again.
+  if (llvm::isa<ReferenceType>(QT.getTypePtr())) {
----------------
s/qualifiy/qualify/


http://reviews.llvm.org/D15861