[PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 4 07:59:02 PST 2016
alexfh added inline comments.
================
Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:19
@@ +18,3 @@
+ }
+
+ // error
----------------
hokein wrote:
> About the internal linkage variable definition, how about only warning the variable in unnamed namespace?
>
> The const/static variable definitions in header are used more widely (We also find there are a lot of such usages in Google code repo), and Google C++ code style doesn't explicitly give suggestions about such const/static usages.
I suggest that we ignore these for now and maybe add an option later.
http://reviews.llvm.org/D15710
More information about the cfe-commits
mailing list