[PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

Matt Stancliff via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 30 08:59:57 PST 2015


mattsta added a comment.

Yeah, I fully understand the need to make sure it doesn't break again (or that this actually fixes it properly), but these changes are about the limit of my LLVM+Tidy internals understanding.  (What's missing from this diff is the 20 hours across 4-6 months where I tried to fix it "properly" but could never figure out how things were getting to an Invalid state to begin with.)

I'll leave this in more capable hands than my own at this point.  It's easy to reproduce the assert failures on large source dirs (a freebsd checkout, an erlang checkout, etc), but I couldn't narrow down what triggers the failures.


Repository:
  rL LLVM

http://reviews.llvm.org/D15797





More information about the cfe-commits mailing list