[PATCH] D15524: [GCC] Attribute ifunc support in clang
Dmitry Polukhin via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 29 01:59:08 PST 2015
DmitryPolukhin added inline comments.
================
Comment at: lib/CodeGen/CodeGenModule.cpp:2700
@@ -2685,3 +2699,3 @@
return;
Aliases.push_back(GD);
----------------
rjmccall wrote:
> Please diagnose that the resolver function has the appropriate type here. Given the constraints, you should be able to do this by inspecting the LLVM function.
I did it in checkAliases because here resolver function may not be available yet.
================
Comment at: lib/Sema/SemaDecl.cpp:2316
@@ -2315,3 +2315,3 @@
? diag::err_alias_after_tentative
: diag::err_redefinition;
S.Diag(VD->getLocation(), Diag) << VD->getDeclName();
----------------
rjmccall wrote:
> Please adjust this diagnostic to say something correct for ifuncs.
It is for VarDecl only so it is not applicable to ifunc.
http://reviews.llvm.org/D15524
More information about the cfe-commits
mailing list