[PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

[Alexander Kornienko via cfe-commits]

alexfh added a subscriber: alexfh.
alexfh added a comment.

Found this accidentally, since I don't read all of cfe-commits normally. Would be nice if you could add me to reviewers on clang-tidy-related patches. Thanks!

In http://reviews.llvm.org/D15121#300837, @dblaikie wrote:

> (tangential: Should we just have a utility function llvm::adl_swap that we
>  could use everywhere rather than having to write two lines for every
>  caller? (& have a variant of this check that knows to suggest that in
>  LLVM?))


FWIW, if this seems to be useful for other codebases, the name of this function could be made configurable (together with the header this function comes from - clang-tidy checks can use `clang::tidy::IncludeInserter` to insert includes in a proper way).


http://reviews.llvm.org/D15121