[PATCH] D12834: add gcc abi_tag support

Evangelos Foutras via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 26 08:46:54 PST 2015

foutrelis added a comment.

In http://reviews.llvm.org/D12834#314136, @elizafox wrote:

> In http://reviews.llvm.org/D12834#311890, @foutrelis wrote:
> > We have received a few reports of clang crashes after applying the abi_tag support patch to our llvm/clang package in Arch Linux.
> Why would you put a patch clearly marked as "needs review" into a distribution?!?!?!?!

We waited 6 months before switching to the new ABI in libstdc++. Ideally, we would have waited until the patch was reviewed and merged but did not want to wait much longer. I also (wrongly) considered the patch to be relative stable.

> In any case, the recursion source seems obvious to me, but I don't know how to add patches to this reviewboard item.

If the correction is obvious as well and not very complex, would you mind sharing it?



More information about the cfe-commits mailing list