[PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

Faisal Vali via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 22 20:29:10 PST 2015

faisalv added a subscriber: Nate.

Comment at: include/clang/AST/DeclTemplate.h:836
@@ -835,2 +835,3 @@
+  bool IsConcept : 1;
rsmith wrote:
> This might make more sense on `TemplateDecl`, since we also want this flag for `VarTemplateDecl`s. In any case, please use some existing spare bit for this rather than making all `FunctionTemplateDecl`s 8 bytes larger by putting it here.
@Nate - since you asked before, if I was to try and do this (now that we know Richard cares strongly about the extra space), I would probably risk complexity (and insult readability) by attempting to smuggle the extra bit into RedeclararableTemplateDecl::CommonBase::InstantiatedFromMember or perhaps within the low bits of the pointer to ReDeclarableTemplateDecl::CommonBase itself (i.e. Common) 
Let's see if Richard has a preference - or suggests a completely different strategy for squirreling.


More information about the cfe-commits mailing list