r256288 - Disable include sorting by default for Chromium style.

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 22 14:42:56 PST 2015


Author: nico
Date: Tue Dec 22 16:42:56 2015
New Revision: 256288

URL: http://llvm.org/viewvc/llvm-project?rev=256288&view=rev
Log:
Disable include sorting by default for Chromium style.

Include sorting generally can break .cc files, especially on Windows.  Make
this opt-in for Chromium style to give us some more time to roll this out.

(Given that the Google style guide is used by many companies, some of them
probably writing code on Windows, one could argue this should be opt-in in
general...)

Modified:
    cfe/trunk/lib/Format/Format.cpp

Modified: cfe/trunk/lib/Format/Format.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=256288&r1=256287&r2=256288&view=diff
==============================================================================
--- cfe/trunk/lib/Format/Format.cpp (original)
+++ cfe/trunk/lib/Format/Format.cpp Tue Dec 22 16:42:56 2015
@@ -607,6 +607,7 @@ FormatStyle getChromiumStyle(FormatStyle
     ChromiumStyle.BinPackParameters = false;
     ChromiumStyle.DerivePointerAlignment = false;
   }
+  ChromiumStyle.SortIncludes = false;
   return ChromiumStyle;
 }
 




More information about the cfe-commits mailing list