[PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

[Anna Zaks via cfe-commits]

zaks.anna added inline comments.

================
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+  StringRef OS = "";
+  if (isTargetMacOS())
+    OS = "osx";
----------------
samsonov wrote:
> Wait, this looks horrible. Can we teach toolchain to give us OS name?
These are not OS names; they are prefixes we use to name the library. I believe "appletvsimulator" would be a platform name, which is too long to append to the dylib name.

I could factor this out into a separate function, but there are no other immediate users. Not sure if the profiler library could be refactored to use it, logic there seems more complicated.


http://reviews.llvm.org/D15624