[PATCH] D15603: [OpenCL] Pipe type support

Xiuli PAN via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 17 03:42:51 PST 2015


pxli168 added inline comments.

================
Comment at: include/clang/AST/Type.h:5020
@@ +5019,3 @@
+/// PipeType - OpenCL20.
+///
+class PipeType : public Type, public llvm::FoldingSetNode {
----------------
bader wrote:
> Xuili, could you apply the comments left by Pekka and Anastasia for the previous version of the patch (http://reviews.llvm.org/D14441). Most of the comments are valid for this patch also.
> Particularly for this line Anastasia asked "Any reason for an empty comment line here?". I think it's not necessary.
I have made some changes to their comments, but I found something still left here. I will fix them.


http://reviews.llvm.org/D15603





More information about the cfe-commits mailing list