[PATCH] D15577: [PS4] Fix the unit test to be compatible with clang driver. NFC

Paul Robinson via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 16 10:50:54 PST 2015


probinson added a subscriber: probinson.
probinson added a comment.

So, mainly you want calls to GetProgramPath not to provide the .exe extension, even on Windows?


================
Comment at: test/Driver/sanitizer-ld.c:382
@@ -381,3 +381,3 @@
 // RUN:   | FileCheck --check-prefix=CHECK-UBSAN-PS4 %s
-// CHECK-UBSAN-PS4: "{{.*}}ld{{(.exe)?}}"
+// CHECK-UBSAN-PS4: "{{.*}}ld{{(.gold.exe)?}}"
 // CHECK-UBSAN-PS4: -lSceDbgUBSanitizer_stub_weak
----------------
This doesn't look right.  If I try this patch on my Windows, without ps4-ld.gold.exe on my PATH, the linker command comes out as "ps4-ld.gold" which does match this regex, but for the wrong reason.
I think you want "{{.*}}ld{{(.gold)?(.exe)?}}" here.


http://reviews.llvm.org/D15577





More information about the cfe-commits mailing list