[PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 15 23:00:06 PST 2015
EricWF added inline comments.
================
Comment at: test/libcxx/test/config.py:364
@@ +363,3 @@
+ deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and
+ cxx_abi == 'none' and
+ not use_llvm_unwinder)
----------------
jroelofs wrote:
> Maybe it makes sense to name this 'auto' instead of 'none'?
I don't think so. I think the CMake option `LIBCXX_CXX_ABI` should learn "auto" instead of "none". Once CMake knows the correct library it can pass that on to the test suite. Currently CMake passes "none" when it knows "libc++.so" exports the ABI library symbols directly.
http://reviews.llvm.org/D13796
More information about the cfe-commits
mailing list