[PATCH] D15539: [libcxxabi] Reducing stack usage of test

Ben Craig via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 15 14:41:12 PST 2015


bcraig added a comment.

In http://reviews.llvm.org/D15539#311343, @jroelofs wrote:

> Could these large padding things be related to the fact that the test is used as a performance check for the implementation? That being said, I have no idea who is paying attention to the numbers that come out of this test (if anyone even is?). Maybe @howard.hinnant knows something about it?


My expectation is that the only thing the padding numbers would effect with regards to execution time would be cache hits and misses.  If there is something subtle going on though, then those sizes need some comments and rationale.  "93481" looks like it was pulled out of a hat, and it is large enough on it's own to overflow many embedded stacks.


http://reviews.llvm.org/D15539





More information about the cfe-commits mailing list