[PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

Tim Northover via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 10:44:50 PST 2015


On 14 December 2015 at 09:20, Eric Christopher via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> I understand the conflicting priorities here for sure. You'd like a test that's as minimal as possible, without having to depend on external (to clang) libraries here. I really would appreciate it if you'd make the test not rely on mem2reg etc so we can be sure that clang's code generation is the thing tested here and not the optimizer. Making sure that the unoptimized output reduces properly would be a great opt test for the backend though.

I think I'm with Alexandros here. Tests based on raw Clang output are
horrific to write and maintain. They end up relying on implementation
details like just how many allocas and reloads Clang decides it needs
for some random expression, even working out whether the test is
correct changes from a pretty trivial eyeballing to keeping track of
dozens of lines of data-flow.

Tim.


More information about the cfe-commits mailing list