[PATCH] D14877: Fix ICE on lowering of constexpr vector splats

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 13 22:50:13 PST 2015


george.burgess.iv updated this revision to Diff 42686.
george.burgess.iv added a comment.

TIL you can use OpenCL vectors in C++ files. Fixed a bug related to not knowing this + added tests for the constexpr cases.

Also, is there a better way to do the `bool` -> `APFloat` conversion in ExprConstant, lines 8108-8110? I'm assuming that float semantics matter, otherwise `Result = APFloat(-BoolResult)` seems nicer.


http://reviews.llvm.org/D14877

Files:
  include/clang/AST/OperationKinds.h
  include/clang/Sema/Sema.h
  lib/AST/Expr.cpp
  lib/AST/ExprConstant.cpp
  lib/CodeGen/CGExpr.cpp
  lib/CodeGen/CGExprAgg.cpp
  lib/CodeGen/CGExprComplex.cpp
  lib/CodeGen/CGExprConstant.cpp
  lib/CodeGen/CGExprScalar.cpp
  lib/Edit/RewriteObjCFoundationAPI.cpp
  lib/Sema/SemaCast.cpp
  lib/Sema/SemaChecking.cpp
  lib/Sema/SemaExpr.cpp
  lib/Sema/SemaExprCXX.cpp
  lib/Sema/SemaOverload.cpp
  lib/StaticAnalyzer/Core/ExprEngineC.cpp
  test/CodeGenCXX/builtins-systemz-zvector.cpp
  test/CodeGenCXX/vector-splat-conversion.cpp
  test/CodeGenOpenCL/bool_cast.cl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14877.42686.patch
Type: text/x-patch
Size: 20500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151214/78db26a0/attachment-0001.bin>


More information about the cfe-commits mailing list