[PATCH] D14329: Show inclusions from a preamble in clang_getInclusions.

[Sergey Kalinichev via cfe-commits]

skalinichev added a subscriber: skalinichev.
skalinichev added a comment.

I've seen this bug too. Generally this patch looks good to me.

Could you also add a test for includes half-way through a file case?


================
Comment at: tools/c-index-test/c-index-test.c:1567
@@ -1564,1 +1566,3 @@
 
+  if (getenv("CINDEXTEST_EDITING"))
+    Repeats = 5;
----------------
This is not a very good idea to add this code here IMO. There are probably some tests that use this function with CINDEXTEST_EDITING set, which could  potentially hide some parsing vs. reparsing bugs. I'd suggest to use something like perform_test_reparse_source instead.


http://reviews.llvm.org/D14329