[patch] Let -Wdelete-non-virtual-dtor mention that making the class final is a good fix too

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 12 06:37:08 PST 2015


Hi,

the attached patch changes

  delete called on 'dnvd::B' that has virtual functions but non-virtual
destructor

to

  delete called on non-final 'dnvd::B' that has virtual functions but
non-virtual destructor

I'm not sure if it should only do this for c++11 and newer – the new
message is true in c++98 as well and I think we support final as an
extension in c++98. So this patch unconditionally changes the warning text.

Nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151212/489dcdf5/attachment.html>


More information about the cfe-commits mailing list