[PATCH] D9600: Add scan-build python implementation

[Laszlo Nagy via cfe-commits]

rizsotto.mailinglist marked 6 inline comments as done.

================
Comment at: tools/scan-build-py/README.md:86
@@ +85,3 @@
+The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload
+is available from the dynamic loader. On OSX System Integrity Protection security
+feature enabled prevents library preload, so this method will not work in such
----------------
zaks.anna wrote:
> This is very unfortunate!
> 
> We should call out that library interposition is "not supported on OS X (unless System Integrity Protection feature is turned off)" and return an error if people are trying to use it (and System Integrity Protection feature is turned on).
comment changed. please hint me with some code how can the script detect SIP status. (or postpone the check implementation after the patch is accepted)

================
Comment at: tools/scan-build-py/bin/analyze-c++:3
@@ +2,3 @@
+# -*- coding: utf-8 -*-
+#                     The LLVM Compiler Infrastructure
+#
----------------
zaks.anna wrote:
> I searched the code and did not see it being called. By looking back at the previous revision I see that that libscanbuild.analyze.main used to call 'analyze-cxx' not 'analyze-c++'. Looks like you've also fixed the same bug with 'intercept-c++'. 
> 
> Is this something that could/would be caught by the tests?
test harness contains only C files, that was the reason this could have gone unnoticed. added specific check for it.


http://reviews.llvm.org/D9600