[PATCH] D15456: [PATCH] New diagnostic for non-idiomatic copy or move operations (v2)

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

I should note that the majority of the changes in this patch are to deal with the diagnostic triggering on test cases. I tried to correct the test cases to be idiomatic where it appears the signature of the operation was not the purpose of the test. The other cases either got an expected-warning, or had the flag disabled.

I ran the diagnostic over several code bases, and the outcome was:

LLVM: 0 warnings
Qt: 7206 warnings (most of these are duplicate diagnostics because the signatures are in a header file)
rethinkdb: 34 warnings (same here)
cocos2d: 0 warnings
opencv: 0 warnings


http://reviews.llvm.org/D15456