[PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 22:54:35 PST 2015


compnerd added inline comments.

================
Comment at: cmake/config-ix.cmake:45
@@ -44,3 +44,3 @@
 check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB)
-check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB)
+check_library_exists(gcc_s __gcc_personality_v0 "" LIBCXXABI_HAS_GCC_S_LIB)
 check_library_exists(c __cxa_thread_atexit_impl ""
----------------
Might be nice to extend this further to allow building against clang_rt.builtins.  We could of course do that as a follow up if you prefer.

================
Comment at: src/CMakeLists.txt:37
@@ +36,3 @@
+
+remove_flags(-Wl,-z,defs)
+
----------------
Do we need to worry about an alternative spelling of `-z defs`?


http://reviews.llvm.org/D15440





More information about the cfe-commits mailing list