[PATCH] D15406: Add warning for attribute-cleanup on function parameter.

[Aaron Ballman via cfe-commits]

aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.

In http://reviews.llvm.org/D15406#307733, @rsmith wrote:

> This looks fine to me, though it would be better to express the restrictions as a `SubjectList` on the attribute definition in `include/clang/Basic/Attr.td` rather than here in code.


It would be nice, but the issue is the unwieldy list of diagnostic enumerations for custom subject lists. I would love to find a way to express the diagnostic replacement for %1 as part of tablegen instead of manually.

FWIW, this LGTM as well.

~Aaron


http://reviews.llvm.org/D15406