PATCH: error on code that redeclares with an __asm__ label after the first ODR use

Nick Lewycky via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 15:15:02 PST 2015


PR22830 shows a case where some code was adding an __asm__ label after the
first use of a function. GCC and Clang diverged on this code, GCC emitting
the name in the last __asm__ label for all uses while clang would switch in
the middle of the TU as the redeclaration was parsed. The attached patch
detects this case and issues an error on such a redeclaration. If this
breaks real code, we can turn it down to a warning.

Please review!

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151210/3c484a99/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr22830-1.patch
Type: text/x-patch
Size: 2163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151210/3c484a99/attachment.bin>


More information about the cfe-commits mailing list