[PATCH] D9600: Add scan-build python implementation

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 10:34:23 PST 2015


zaks.anna added inline comments.

================
Comment at: tools/scan-build-py/bin/analyze-c++:2
@@ +1,3 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#                     The LLVM Compiler Infrastructure
----------------
Where/How is analyze-c++ used?

================
Comment at: tools/scan-build-py/bin/analyze-cc:14
@@ +13,2 @@
+from libscanbuild.analyze import wrapper
+sys.exit(wrapper(False))
----------------
I believe this is an important point. Fixing this would greatly improve readability!

================
Comment at: tools/scan-build-py/libear/ear.c:282
@@ +281,3 @@
+    DLSYM(func, fp, "execve");
+
+    char const **const menvp = bear_update_environment(envp, &initial_env);
----------------
rizsotto.mailinglist wrote:
> okay, since i don't have access for OSX machines can you help me to make it right?
Ok. Will do.


http://reviews.llvm.org/D9600





More information about the cfe-commits mailing list