[PATCH] D13351: [Power PC] add soft float support for ppc32

John McCall via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 07:56:54 PST 2015


rjmccall added inline comments.

================
Comment at: lib/Driver/Tools.cpp:1477
@@ +1476,3 @@
+  // If unspecified, choose the default based on the platform.
+  if (ABI == ppc::FloatABI::Invalid) {
+    ABI = ppc::FloatABI::Hard;
----------------
hfinkel wrote:
> Don't need the { } here.
We don't seem to have a specific style guideline *mandating* the uses of braces around even single-line statements, but please don't *discourage* them.


http://reviews.llvm.org/D13351





More information about the cfe-commits mailing list