[PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

[David Majnemer via cfe-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/CodeGen/CGStmt.cpp:2005
@@ -1998,3 +2004,3 @@
                          /* IsAlignStack */ false, AsmDialect);
   llvm::CallInst *Result = Builder.CreateCall(IA, Args);
   Result->addAttribute(llvm::AttributeSet::FunctionIndex,
----------------
rnk wrote:
> If this inline asm has labels, we should also add the noduplicate attribute to the callsite. That will prevent CFG transforms like tail duplication from duplicating it.
Actually, isn't noduplicate sufficient?  I'm having trouble seeing where noinline inhibits problematic transforms over noduplicate.


http://reviews.llvm.org/D15399