[PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

[Eric Fiselier via cfe-commits]

EricWF added a comment.

In http://reviews.llvm.org/D14409#306531, @eugenis wrote:

> In http://reviews.llvm.org/D14409#306379, @eugenis wrote:
>
> > In http://reviews.llvm.org/D14409#306272, @EricWF wrote:
> >
> > > Does the `inline` keyword have any effect when it's on function definitions that are externally instantiated?
> >
> >
> > I could not detect any difference in behavior with or without inline keyword.
> >  Remove it?
>
>
> Actually, remove the inline breaks tests, because now the method is declared hidden (in-class), so template instantiation in libc++.so produces a hidden symbol.
>
> As an alternative, we could remove both "inline" and the in-class hidden attribute.


That change would be an ABI break. This change is perfect as-is.


Repository:
  rL LLVM

http://reviews.llvm.org/D14409