[PATCH] D15161: [CMake] On Darwin the LIBCXX_INSTALL_HEADERS and LIBCXX_INSTALL_LIBRARY options should default off

[Chris Bieneman via cfe-commits]

beanz abandoned this revision.
beanz added a comment.

Short answer. I was doing something terrible and wrong in out-of-tree code, and this was getting tripped up. I was reading the LIBCXX_INSTALL_* variables from a higher-level CMake file. I've stopped doing that (because it was stupid), so I'll abandon this patch.

For context the CMake behavior I was hitting was this:

CMakeLists.txt:

  add_subdirectory(foo)
  message(STATUS "VAR = ${VAR}") # prints On

foo/CMakeLists.txt:

  option(VAR "description" ON)
  set(VAR OFF)
  message(STATUS "VAR = ${VAR}") # prints OFF

Overriding a cached variable in CMake only overrides it in the current scope and lower.


http://reviews.llvm.org/D15161