[PATCH] D15208: Patch for inline abort code generation

Alexey Samsonov via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 9 14:08:50 PST 2015


samsonov added inline comments.

================
Comment at: lib/CodeGen/CGExpr.cpp:2543
@@ +2542,3 @@
+  // RE: Bug: 25682
+  if(!getLangOpts().mergeTraps) {
+      llvm::InlineAsm *EmptyAsm = llvm::InlineAsm::get(llvm::FunctionType::get(CGM.VoidTy, false), 
----------------
danielaustin wrote:
> samsonov wrote:
> > Note that this will also affect `-ftrapv`, which might be unexpected, as we mention "sanitize" in the flag name.
> Would it be better in your opinion to remove sanitize from the name, or check for the presence of the integer sanitizers here?
Probably former - we already have `-ftrap-function` which changes the behavior of both sanitizer-generated and regular traps - this flag is no different.


Repository:
  rL LLVM

http://reviews.llvm.org/D15208





More information about the cfe-commits mailing list