[PATCH] D15208: Patch for inline abort code generation

Alexey Samsonov via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 8 13:04:07 PST 2015


samsonov added a comment.

Sorry for the late response. Ugh, flag naming is hard, and it's far too complicated for sanitizers already.

However, I'm opposed to passing this down as `-fsanitize=` option =/. So far we're trying to make values of `-fsanitize=` correspond *only* to different kinds of checks, not configuration modes. For instance, we've pushed back against somewhat similar feature request for CFI: original plan for enabling "debug mode" in CFI was to pass "-fsanitize=cfi-diag", but we instead changed it to be "-fsanitize=cfi -fno-sanitize-trap=cfi".

And we have three possible configurations: recoverable checks, fatal/unrecoverable checks, trapping checks. You need, essentially "trapping-but-distinguishable checks". I'm afraid adding fourth configuration will make things incomprehensible. `-fsanitize-merge-traps` (true by default)?


Repository:
  rL LLVM

http://reviews.llvm.org/D15208





More information about the cfe-commits mailing list