[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

Argyrios Kyrtzidis via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 8 11:46:22 PST 2015


akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.

For CX_BinaryOperatorKind please change the enumerators to have an explicit integer assignment; this is to emphasize that they are API contract and should not change with subsequent changes (someone may inadvertently add a new enumerator in the middle which will implicitly change all the subsequent enumerators).

Otherwise LGTM.


http://reviews.llvm.org/D10833





More information about the cfe-commits mailing list