[PATCH] D15120: Add support for __float128 type to be used by targets that support it

[Argyrios Kyrtzidis via cfe-commits]

> On Dec 7, 2015, at 12:16 AM, John McCall <rjmccall at gmail.com> wrote:
> 
> rjmccall added a reviewer: akyrtzi.
> 
> ================
> Comment at: lib/AST/ASTContext.cpp:5424
> @@ -5410,1 +5423,3 @@
> +    // FIXME: need to figure out what this is for __float128
> +    case BuiltinType::Float128:   return 'K';
>     case BuiltinType::NullPtr:    return '*'; // like char*
> ----------------
> Please add this as a case to the block below for Half.  I'll ping internally for a decision on what @encoding to use.
> 
> ================
> Comment at: lib/Index/USRGeneration.cpp:604
> @@ -602,1 +603,3 @@
> +        case BuiltinType::Float128:
> +          c = ' '; break;
>         case BuiltinType::NullPtr:
> ----------------
> I'm pretty sure you can just choose something here that doesn't collide, but the right person to ask is Argyrios.

Indeed; I don’t have a preference, just something that doesn’t collide.

> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D15120
> 
> 
>