[PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.
John McCall via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 4 14:50:31 PST 2015
rjmccall added inline comments.
================
Comment at: lib/Sema/SemaPseudoObject.cpp:232
@@ -231,3 +231,3 @@
/// Return true if assignments have a non-void result.
- bool CanCaptureValue(Expr *exp) {
+ bool CanCaptureValue(Expr *exp) const {
if (exp->isGLValue())
----------------
Just make this static.
================
Comment at: lib/Sema/SemaPseudoObject.cpp:464
@@ -461,1 +463,3 @@
+ if (useSetterResultAsExprResult(result.get()))
+ setResultToLastSemantic();
----------------
This will leave the result as the captured set value if it can't capture the setter result. Is that desired?
http://reviews.llvm.org/D15174
More information about the cfe-commits
mailing list