[clang-tools-extra] r254635 - Fixed header determination logic. Was missing extensionless headers in coverage check.

[John Thompson via cfe-commits]

I think you're right, though I don't understand why I don't see the failure
locally.  I will fix it or back it out.


On Fri, Dec 4, 2015 at 9:52 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Still missing test coverage?
>
> And I'm going to go out on a limb and guess this commit might be
> responsible for this ongoing regression:
> http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/26746
> (no other commits in that build seem like likely candidates)
>
> On Thu, Dec 3, 2015 at 11:38 AM, David Blaikie <dblaikie at gmail.com> wrote:
>
>> test case?
>>
>> On Thu, Dec 3, 2015 at 11:20 AM, John Thompson via cfe-commits <
>> cfe-commits at lists.llvm.org> wrote:
>>
>>> Author: jtsoftware
>>> Date: Thu Dec  3 13:20:43 2015
>>> New Revision: 254635
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=254635&view=rev
>>> Log:
>>> Fixed header determination logic. Was missing extensionless headers in
>>> coverage check.
>>>
>>> Modified:
>>>     clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp
>>>
>>> Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp?rev=254635&r1=254634&r2=254635&view=diff
>>>
>>> ==============================================================================
>>> --- clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp (original)
>>> +++ clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp Thu Dec
>>> 3 13:20:43 2015
>>> @@ -468,7 +468,7 @@ std::string ModularizeUtilities::getCano
>>>  bool ModularizeUtilities::isHeader(StringRef FileName) {
>>>    StringRef Extension = llvm::sys::path::extension(FileName);
>>>    if (Extension.size() == 0)
>>> -    return false;
>>> +    return true;
>>>    if (Extension.equals_lower(".h"))
>>>      return true;
>>>    if (Extension.equals_lower(".inc"))
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>>
>>
>>
>


-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151204/6308fadd/attachment.html>