[PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 4 00:26:12 PST 2015


ABataev added inline comments.

================
Comment at: include/clang-c/Index.h:2263-2267
@@ -2262,3 +2262,7 @@
 
-  CXCursor_LastStmt                      = CXCursor_OMPTaskLoopDirective,
+   /** \brief OpenMP distribute directive.
+   */
+  CXCursor_OMPDistributeDirective        = 259,
+
+  CXCursor_LastStmt                      = CXCursor_OMPDistributeDirective,
 
----------------
Update it to the latest changes

================
Comment at: include/clang/AST/OpenMPClause.h:708-709
@@ -707,4 +707,4 @@
 public:
-  /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk size
-  /// expression \a ChunkSize.
+  /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk
+  /// size expression \a ChunkSize.
   ///
----------------
Revert back these changes, this comment should not be modified

================
Comment at: include/clang/AST/StmtOpenMP.h:2282
@@ +2281,3 @@
+///
+class OMPDistributeDirective : public OMPLoopDirective {
+  friend class ASTStmtReader;
----------------
You forget to modify OMPLoopDirective::classof()

================
Comment at: lib/Basic/OpenMPKinds.cpp:460
@@ -449,4 +459,3 @@
          DKind == OMPD_single || DKind == OMPD_parallel_for ||
-         DKind == OMPD_parallel_for_simd ||
-         DKind == OMPD_parallel_sections; // TODO add next directives.
+         DKind == OMPD_parallel_for_simd || DKind == OMPD_parallel_sections; // TODO add next directives.
 }
----------------
Revert these changes back

================
Comment at: lib/Parse/ParseOpenMP.cpp:162
@@ -160,3 +161,3 @@
 ///         'for simd' | 'parallel for simd' | 'target' | 'target data' |
-///         'taskgroup' | 'teams' {clause}
+///         'taskgroup' | 'teams' {clause} | 'distribute' {clause}
 ///         annot_pragma_openmp_end
----------------
Remove {clause} after 'teams'

================
Comment at: lib/Parse/ParseOpenMP.cpp:402
@@ -399,3 +401,3 @@
 ///       simdlen-clause | threads-clause | simd-clause | num_teams-clause |
-///       thread_limit-clause | priority-clause
+/// 		  thread_limit-clause | priority-clause
 ///
----------------
Revert back these changes

================
Comment at: lib/Parse/ParseOpenMP.cpp:684
@@ -681,3 +683,3 @@
   bool NeedAnExpression =
-      (Kind == OMPC_schedule && DelimLoc.isValid()) || Kind == OMPC_if;
+      (Kind == OMPC_schedule && DelimLoc.isValid()) ||Kind == OMPC_if;
   if (NeedAnExpression) {
----------------
Revert back these changes


Repository:
  rL LLVM

http://reviews.llvm.org/D15125





More information about the cfe-commits mailing list