[PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

Mehdi AMINI via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 3 18:07:40 PST 2015


joker.eph added a comment.

Talked with Duncan, we're not convinced about //-fthinlto-backend=...// for the option name: the word //backend// does not seems right here. What about //-fthinlto-index=...//?


================
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+      TheModule = std::move(Combined);
+    }
+
----------------
Could we refactor this in a helper in llvm?

================
Comment at: test/Driver/thinlto_backend.c:6
@@ +5,3 @@
+// RUN: %clang -target x86_64-unknown-linux -O2 -o %t1.o -x ir %t.o -c -fthinlto-backend=%t.thinlto.bc -### 2> %t
+// RUN: FileCheck -check-prefix=CHECK-THINLTOBE-ACTION < %t %s
+// CHECK-THINLTOBE-ACTION: -fthinlto-backend=
----------------
Why not pipe to FileCheck here?


http://reviews.llvm.org/D15025





More information about the cfe-commits mailing list