[PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

[Alexander Droste via cfe-commits]

Alexander_Droste added a comment.

Hi,

I think the points mentioned should be all addressed now.
The only thing left is that some of the more generic functionality 
maybe should be moved from MPI-Checker related files to others.
Therefor,  I need some advice where to put these functions (if necessary).


================
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Container.h:31
@@ +30,2 @@
+
+#endif
----------------
I just found `/include/llvm/ADT/STLExtras.h`. Wouldn't that be a good fit for the `contains()` function?

================
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPICheckerPathSensitive.cpp:107
@@ +106,3 @@
+      State = State->remove<RequestMap>(Req.first);
+    }
+  }
----------------
I need `addTransition()` later to take removed requests into account.


http://reviews.llvm.org/D12761