r254515 - Amending r254423 by deleting the copy constructor and adding a move constructor instead; NFC as neither of these constructors are currently called, but this is a safer design.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 11:39:09 PST 2015


On Wed, Dec 2, 2015 at 1:00 PM, David Blaikie <dblaikie at gmail.com> wrote:
> Oh, this type has a user-defined dtor, so it's deprecated to use the
> implicit copy ctor/assignment operator anyway - and I have the -Wdeprecated
> flag on in my build (& keep the LLVM build clean of any warnings it shows).
>
> At some point (would love help) we should just turn that on for everyone,
> then we wouldn't have to worry about types like this -Wdeprecated -Werror
> would catch them. I think last time I tried to turn it on there were some
> things in library headers, perhaps (maybe in cxxabi?) that needed cleaning
> up that I didn't have/build/see locally...

I would be amenable to turning that on for everyone if we can get away with it.

~Aaron


More information about the cfe-commits mailing list