[PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

John McCall via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 09:42:41 PST 2015


rjmccall added inline comments.

================
Comment at: lib/AST/RecordLayoutBuilder.cpp:1606
@@ -1605,1 +1605,3 @@
+    } else if (ExplicitFieldAlign)
+      FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAlign);
 
----------------
Be sure to test specifically with an APCS ARM target; newer ARM ABIs don't ignore bit-field layout. Sorry, I should have been more explicit about that. (You can figure this stuff out by looking at the various targets in Targets.cpp that set UseBitFieldTypeAlignment.)


http://reviews.llvm.org/D14980





More information about the cfe-commits mailing list