[PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

[Kelvin Li via cfe-commits]

kkwli0 added inline comments.

================
Comment at: include/clang/AST/OpenMPClause.h:708
@@ -707,3 +707,3 @@
 public:
-  /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk size
-  /// expression \a ChunkSize.
+  /// \brief Build 'dist_schedule' clause with schedule kind \a Kind and chunk
+  /// size expression \a ChunkSize.
----------------
Is it 'schedule'?

================
Comment at: include/clang/AST/OpenMPClause.h:835
@@ +834,3 @@
+public:
+  /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk size
+  /// expression \a ChunkSize.
----------------
'dist_schedule'

================
Comment at: lib/Parse/ParseOpenMP.cpp:670
@@ -666,1 +669,3 @@
       DelimLoc = ConsumeAnyToken();
+  } else if (Kind == OMPC_dist_schedule) {
+    Arg = getOpenMPSimpleClauseType(
----------------
Can we merge it with the OMPC_schedule block?  The code is similar.

================
Comment at: lib/Sema/SemaOpenMP.cpp:5780
@@ +5779,3 @@
+  if (ChunkSize) {
+    if (!ChunkSize->isValueDependent() && !ChunkSize->isTypeDependent() &&
+        !ChunkSize->isInstantiationDependent() &&
----------------
Is the IsNotNegativeIntegerValue useful in this case?

================
Comment at: tools/libclang/CIndex.cpp:4489
@@ -4477,1 +4488,3 @@
+  case CXCursor_OMPDistributeDirective:
+    return cxstring::createRef("OMPForDirective");
   case CXCursor_OverloadCandidate:
----------------
"OMPDistributeDirective"


Repository:
  rL LLVM

http://reviews.llvm.org/D15125