[PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

John McCall via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 1 11:49:13 PST 2015


rjmccall added inline comments.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2790
@@ -2790,1 +2789,3 @@
+  "version 4.4 - the newer offset is used here">,
+  InGroup<DiagGroup<"attribute-packed-for-bitfield-offset-changed">>;
 def warn_transparent_union_attribute_field_size_align : Warning<
----------------
No, this diagnostic shouldn't make such an affirmative statement about the offset changing.  I would instead suggest:
  warning: 'packed' attribute was ignored on bit-fields with alignment 1 in older versions of GCC and Clang


http://reviews.llvm.org/D14872





More information about the cfe-commits mailing list