[PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

Beren Minor via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 1 05:46:10 PST 2015


berenm added a comment.

I don't have any compilation error with GCC 5.2.1. I tried again with Clang 3.8 and indeed there is this error:

  tools/clang/lib/Format/WhitespaceManager.cpp:155:51: error: 'Change' is a private member of 'clang::format::WhitespaceManager'
                     SmallVector<WhitespaceManager::Change, 16> &Changes) {
                                                    ^
  tools/clang/lib/Format/WhitespaceManager.h:87:10: note: declared private here
    struct Change {
           ^

This can easily be reproduced: http://goo.gl/CUk665 vs http://goo.gl/6KcBFT

I don't know precisely which one is correct here, it looks like to be related to the access permission in the context of a template function instantiation.


http://reviews.llvm.org/D14325





More information about the cfe-commits mailing list