[PATCH] Don't crash when dumping objc_bridge_related attributes

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 30 07:28:31 PST 2015


On Thu, Nov 26, 2015 at 12:00 PM, Joe Ranieri <joe at alacatialabs.com> wrote:
> On Thu, Nov 26, 2015 at 11:29 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri <joe at alacatialabs.com> wrote:
>>> Clang's AST dumping currently crashes when dumping objc_bridge_related
>>> attributes where the class method and instance method fields are left
>>> empty. The attached patch marks the two arguments as optional and
>>> updates TableGen to understand the optional flag for identifier
>>> attribute arguments when generating the dump function.
>>
>> LGTM, thank you! Do you have commit privileges, or would you like me
>> to commit on your behalf?
>>
>> ~Aaron
>
> Please commit on my behalf.

Thanks! I've commit in r254303

~Aaron


More information about the cfe-commits mailing list